Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10433 - Email Address ID being double quoted #10434

Open
wants to merge 1 commit into
base: hotfix
Choose a base branch
from

Conversation

azzy9
Copy link

@azzy9 azzy9 commented May 21, 2024

Description

Issue: #10433
Fixes issue of the email address ID being double quoted which causes a mysql error in the log.
It gets quoted previously at: https://github.com/salesagility/SuiteCRM/blob/hotfix/include/SugarEmailAddress/SugarEmailAddress.php#L462
$_id = $db->quoted($id);

Motivation and Context

Stops MySQL error in log

How To Test This

Go to user in Admin, edit email address and then check log for error.
This fix stops the error.

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • [x ] My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • [ x] I have read the How to Contribute guidelines.

@SuiteBot
Copy link

SuiteBot commented May 21, 2024

CLA assistant check
All committers have signed the CLA.

@serhiisamko091184 serhiisamko091184 added Status: Requires Code Review Needs the core team to code review Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Branch:Hotfix PR 4-8 Score given to PRs once assessed labels May 22, 2024
@serhiisamko091184
Copy link
Contributor

Hello @azzy9,

thanks for your contribution to the SuiteCRM Project!

Regards,
Serhii

@jack7anderson7 jack7anderson7 added Status: Requires Testing Requires Manual Testing Status: Passed Code Review Mark issue has passed code review reviewed and removed Status: Requires Code Review Needs the core team to code review labels May 23, 2024
@johnM2401 johnM2401 added Status: Passed Testing and removed Status: Requires Testing Requires Manual Testing labels Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Branch:Hotfix PR 4-8 Score given to PRs once assessed Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Passed Code Review Mark issue has passed code review reviewed Status: Passed Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants