Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Field instance reuse workaround #1730

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

lundybernard
Copy link
Contributor

Fixes: #1680

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.55%. Comparing base (812b2a8) to head (63886fa).
Report is 119 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1730      +/-   ##
==========================================
- Coverage   94.28%   93.55%   -0.73%     
==========================================
  Files          91      117      +26     
  Lines        7013     8843    +1830     
==========================================
+ Hits         6612     8273    +1661     
- Misses        401      570     +169     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lundybernard
Copy link
Contributor Author

@cosmicBboy Your update looks good to me.
I'm not sure what to do about the codecov/project failure, it looks like there is an inconsistency in the coverage report which is unrelated to this change.

@cosmicBboy cosmicBboy merged commit 3f5e43e into unionai-oss:main Jul 8, 2024
179 of 180 checks passed
@lundybernard lundybernard deleted the docs/1680 branch July 9, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reusing Field objects causes unexpected failure
2 participants