Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(next-swc): always set useWasmBinary based on config in loadBindings - fixes #62059 #67420

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

obiwac
Copy link

@obiwac obiwac commented Jul 3, 2024

Fixes #62059

Currently, the experimental.useWasmBinary option is ignored when doing a next build, because SWC transpilation never sets the useWasmBinary parameter in loadBindings. I tried passing the option everywhere loadBindings is called but this was getting very cumbersome so I opted to read the option at the top of loadBindings, and, if it's set, set useWasmBinary to true.

I don't know if there's a better way to load the options for this, and I'll gladly change this is there is.

Another related issue which prevented this option from working has already been fixed in #65633.

@ijjk ijjk added the type: next label Jul 3, 2024
@ijjk
Copy link
Member

ijjk commented Jul 3, 2024

Allow CI Workflow Run

  • approve CI run for commit: 2a74525

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

timneutkens

This comment was marked as resolved.

Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks incorrect, it's trying to load next.config.js again. Instead the option should be passed through in the places where loadBindings is called.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useWasmBinary option is not working in some conditions
3 participants